Thanks, Larry for your feedback.

Let me try to reply them one by one:

> * Tried Token Management page and found an issue with the default
> deployment - see screenshots - NOT good
As indicated offline, this is kind of works as designed. Knox's public 
documentation emphasizes that end users need to provision the 
'knox.token.hash.key' gateway-level alias to use Token Management and Token 
Generation pages from the homepage topology.
You raised a valid point that we could do better in terms of visual feedback in 
this case, so I filed https://issues.apache.org/jira/browse/KNOX-3187 to 
improve this area. It's fixed now and will be included in RC2.

> * Checked NOTICE, README, LICENSE and CHANGES files - noticed an issue in
> there - NOT good
There were two issues with the CHANGES file generation in RC1:
- OPEN JIRA items were not yet moved to the next release (3.0.0)
- The Apache ReleaseNotes resource do not have capabilities to apply filters 
based on Status/Resolution. Therefore I regenerated the file using a different 
approach: searched for the list of work items in JIRA using the "project = KNOX 
AND status in (Resolved, Closed) AND resolution in (Fixed, Invalid, Done, 
Resolved) AND fixVersion = 2.1.0" filter and then converted the output into 
CHANGES format with a Python script.
Prior to the work item filtering I moved out OPEN 2.1.0/2.2.0 items to 3.0.0 
using JIRA's bulk update tool.

In addition to addressing your concerns, Sandeep More reached out to me that 
his fix for KNOX-3186 should be included in 2.1.0. Since a new RC was 
necessary, I included that fix in RC2.

I'll send out a VOTE email soon.


On 2025/09/06 17:33:21 larry mccay wrote:
> Thanks for the RC, Sandor.
> 
> I've done some testing and found a couple things to address before we can
> release.
> 
> -1
> 
> * Verified Signatures - good
> * Built from source and ran tests - good
> * Exercised SSO and access to the homepage - good
> * Tried Token Management page and found an issue with the default
> deployment - see screenshots - NOT good
> * Checked NOTICE, README, LICENSE and CHANGES files - noticed an issue in
> there - NOT good
>      - some listed issues are not actually included as far as I know - such
> as KNOX-929
> 
> [image: image.png]
> 
> [image: image.png]
> 
> 
> 
> On Mon, Aug 25, 2025 at 4:09 AM Sandor Molnar <smol...@apache.org> wrote:
> 
> > Release candidate #1 for the Apache Knox 2.1.0 release is available at:
> > https://dist.apache.org/repos/dist/dev/knox/knox-2.1.0/
> >
> > The release candidate is a zip archive of the sources in:
> > https://https://gitbox.apache.org/repos/asf/knox.git
> > Branch v2.1.0 (git checkout -b v2.1.0)
> >
> > The KEYS file for signature validation is available at:
> > https://dist.apache.org/repos/dist/release/knox/KEYS
> >
> > Please find the most recent changes here:
> > https://github.com/apache/knox/blob/v2.1.0/CHANGES
> >
> > KnoxShell User Guide:
> > https://knox.apache.org/books/knox-2-1-0/knoxshell_user_guide.html
> >
> > Gateway User Guide:
> > http://knox.apache.org/books/knox-2-1-0/user-guide.html
> >
> > Dev Guide:
> > http://knox.apache.org/books/knox-2-1-0/dev-guide.html
> >
> > Please vote on releasing this package as Apache Knox 2.1.0.
> > The vote is open for the next 120 hours and passes if a majority of at
> > least three +1 Apache Knox PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Knox 2.1.0
> > [ ] -1 Do not release this package because...
> >
> > Thanks,
> > Sandor
> >
> 

Reply via email to