moresandeep commented on PR #1116: URL: https://github.com/apache/knox/pull/1116#issuecomment-3607721799
> * elated tests Great question, I can tell you putting all tests in one file would be a nightmare! what we can do is we can either 1. Group the tests in one single file (multiple tests per file) 2. Group tests in sub-folders (sub folder needs to have `__init__.py` file (it can be empty)) > Is there a way to disable these tests on specific PRs that don't need them to run? Good idea, i updated the logic to skip tests based on label `skip-tests` but this skips all the tests. I don't currently have a way to skip a specific test though. I am open to suggestions though. > Why are there two docker files? Does the local have to be included in the repo? I am assuming you are referring to `Dockerfile` and `Dockerfile.local` `Dockerfile` is used by workflow, `Dockerfile.local` is used to create knox image on any dockerized environment. The reason for including this is, firstly it helps in local testing and secondly, in case we move to other env (i.e. non github workflow env) we can port this code easily. Hopefully this helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
