[
https://issues.apache.org/jira/browse/KNOX-3228?focusedWorklogId=995283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-995283
]
ASF GitHub Bot logged work on KNOX-3228:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/25 19:08
Start Date: 08/Dec/25 19:08
Worklog Time Spent: 10m
Work Description: moresandeep commented on code in PR #1123:
URL: https://github.com/apache/knox/pull/1123#discussion_r2599802165
##########
.github/workflows/tests/requirements.txt:
##########
@@ -1,2 +1,3 @@
requests
+docker
Review Comment:
I have changes in this file, I am pinning version based on
@Raghav-Mah3shwari 's input, that i will be committing. You will need to
rebase, sorry :(
##########
.github/workflows/tests/test_knox_cli.py:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+import unittest
+from util.knox import Knox
+
Review Comment:
Test description would be nice!
##########
.github/workflows/compose/docker-compose.yml:
##########
@@ -50,6 +50,7 @@ services:
working_dir: /tests
volumes:
- ../tests:/tests
+ - /var/run/docker.sock:/var/run/docker.sock
Review Comment:
Why do we need this? This looks like a change needed for local runs.
Issue Time Tracking
-------------------
Worklog Id: (was: 995283)
Time Spent: 20m (was: 10m)
> KnoxCLI integration test
> ------------------------
>
> Key: KNOX-3228
> URL: https://issues.apache.org/jira/browse/KNOX-3228
> Project: Apache Knox
> Issue Type: Test
> Components: Tests
> Affects Versions: 3.0.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adds a new integration test for create-list-aliases KnoxCLI command.
> Adds the necessary steps and libraries to call KnoxCLI commands in
> integration tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
