[
https://issues.apache.org/jira/browse/KNOX-3232?focusedWorklogId=996213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996213
]
ASF GitHub Bot logged work on KNOX-3232:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/25 13:35
Start Date: 15/Dec/25 13:35
Worklog Time Spent: 10m
Work Description: bonampak opened a new pull request, #1132:
URL: https://github.com/apache/knox/pull/1132
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
[KNOX-1234](https://issues.apache.org/jira/browse/KNOX-3232) - Handle pac4j
cookies with "null" value
## What changes were proposed in this pull request?
Just handle the case when our set-cookie header is setting explicit null
values and KnoxSessionStore receives the cookie with "null" value.
## How was this patch tested?
Manual test with CAS global logout url as described in the JIRA.
Added a unit test in KnoxSessionStoreTests.
Issue Time Tracking
-------------------
Worklog Id: (was: 996213)
Remaining Estimate: 0h
Time Spent: 10m
> Handle pac4j cookies with "null" value
> --------------------------------------
>
> Key: KNOX-3232
> URL: https://issues.apache.org/jira/browse/KNOX-3232
> Project: Apache Knox
> Issue Type: Task
> Components: KnoxSSO
> Affects Versions: 3.0.0
> Reporter: Tamás Marcinkovics
> Assignee: Tamás Marcinkovics
> Priority: Major
> Attachments: knoxsso-cas-test.xml
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When testing Knox SSO with Pac4j and CAS, if the user clicks on global
> logout, and does not close the browser, refreshing the homepage link results
> in a 500 internal server error due to KnoxSessionStore not being able to get
> the value of CasClient$attemptedAuthentication cookie.
> When pac4j calls the
> KnoxSessionStore.set() method with null value, we will add a
> Set-Cookie-Header with "null" value instead of empty.
> setCookieHeader = new SetCookieHeader(PAC4J_SESSION_PREFIX + key, null);
> When KnoxSessionStore.get() is called, it tries to uncompress the non-empty
> value and fails with a BufferUnderflowException.
>
> To test, replace the conf/knoxsso.xml with the contents of the attached
> knoxsso-cas-test.xml and set global logout in gateway-site.xml by setting the
> properties
> {noformat}
> <property>
> <name>knox.homepage.logout.enabled</name>
> <value>true</value>
> </property>
> <property>
> <name>knox.global.logout.page.url</name>
> <value>https://casserverpac4j.herokuapp.com/logout</value>
> </property>
> {noformat}
>
> Then log in to CAS using the same username and password, then in the knox
> homepage press the logout and global logout link afterwards.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
