[
https://issues.apache.org/jira/browse/KNOX-3236?focusedWorklogId=998853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-998853
]
ASF GitHub Bot logged work on KNOX-3236:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/26 19:30
Start Date: 06/Jan/26 19:30
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1135:
URL: https://github.com/apache/knox/pull/1135#discussion_r2666045096
##########
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java:
##########
@@ -42,15 +42,14 @@ public final void log( final StackTraceElement caller,
final MessageLevel messag
}
private static Level toLevel(final MessageLevel level ) {
- switch( level ) {
- case FATAL: return Level.FATAL;
- case ERROR: return Level.ERROR;
- case WARN: return Level.WARN;
- case INFO: return Level.INFO;
- case DEBUG: return Level.DEBUG;
- case TRACE: return Level.TRACE;
- default: return Level.OFF;
Review Comment:
```
public enum MessageLevel {
FATAL, ERROR, WARN, INFO, DEBUG, TRACE
}
```
All cases are handled, no need for the 'default' case.
Issue Time Tracking
-------------------
Worklog Id: (was: 998853)
Time Spent: 50m (was: 40m)
> Upgrade Maven PMD plugin to 3.28.0
> ----------------------------------
>
> Key: KNOX-3236
> URL: https://issues.apache.org/jira/browse/KNOX-3236
> Project: Apache Knox
> Issue Type: Task
> Components: Build
> Affects Versions: 2.1.0, 3.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: image-2026-01-06-13-56-44-933.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I noticed that my build occasionally hanging here:
> {code:java}
> [INFO] --- pmd:3.26.0:pmd (pmd) @ gateway-provider-security-shiro ---
> [INFO] PMD version: 7.7.0 {code}
> The last time it happened I got a thread dump (see attachment) which
> confirmed my suspicion that PMD indeed has an intermittent issue running on
> multiple threads.
> I also found this bug of theirs: [https://github.com/pmd/pmd/issues/5293]
> So, I checked and found that the latest Maven PMD plugin version, 3.28.0,
> comes with PMD 7.17.0, where this issue is resolved.
> !image-2026-01-06-13-56-44-933.png|height=400!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
