[
https://issues.apache.org/jira/browse/KNOX-3245?focusedWorklogId=1002506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1002506
]
ASF GitHub Bot logged work on KNOX-3245:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/26 14:44
Start Date: 29/Jan/26 14:44
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1142:
URL: https://github.com/apache/knox/pull/1142#discussion_r2741992331
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java:
##########
@@ -228,7 +228,7 @@ public Object buildSslContextFactory(GatewayConfig config)
throws AliasServiceEx
}
final Set<String> sslIncludeProtocols = config.getIncludedSSLProtocols();
- if (sslIncludeProtocols != null && sslIncludeProtocols.isEmpty()) {
+ if (sslIncludeProtocols != null && !sslIncludeProtocols.isEmpty()) {
Review Comment:
Nice catch!
Issue Time Tracking
-------------------
Worklog Id: (was: 1002506)
Time Spent: 0.5h (was: 20m)
> SSL ciphers and protocols separator to support ':', '\n' and ','
> ----------------------------------------------------------------
>
> Key: KNOX-3245
> URL: https://issues.apache.org/jira/browse/KNOX-3245
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 3.0.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently ssl ciphers and protocols can only be separated by comma. This can
> be extended with ':' and {{{}'\n{}}}' as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
