nileshrathi345 commented on PR #1143:
URL: https://github.com/apache/knox/pull/1143#issuecomment-3834888853

   > Hi @nileshrathi345 !
   > 
   > Thanks for your contribution. If I understood well, your change is driven 
by the fact that upstream components may decompress the body without updating 
headers, especially in HA or proxy chains (e.g. with NGNIX in place before 
Knox).
   > 
   > The gzip signature check already exists for this reason and should be 
authoritative. Therefore we should only construct a GzipCompressorInputStream 
when the signature confirms gzip and eliminate the uncertainty with the header 
(which may or may not be correct).
   > 
   > Is this correct?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to