[
https://issues.apache.org/jira/browse/KNOX-3252?focusedWorklogId=1005093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1005093
]
ASF GitHub Bot logged work on KNOX-3252:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/26 14:27
Start Date: 13/Feb/26 14:27
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #1146:
URL: https://github.com/apache/knox/pull/1146#discussion_r2804494200
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/TokenStateDatabase.java:
##########
@@ -60,11 +66,20 @@ public class TokenStateDatabase {
private final DataSource dataSource;
+ private static final String POSTGRES_DUPLICATE_OBJECT_STATE = "42710";
+
TokenStateDatabase(DataSource dataSource, String dbType) throws Exception {
this.dataSource = dataSource;
DatabaseType databaseType = DatabaseType.fromString(dbType);
- createTableIfNotExists(TOKENS_TABLE_NAME, databaseType.tokensTableSql());
- createTableIfNotExists(TOKEN_METADATA_TABLE_NAME,
databaseType.metadataTableSql());
+ try {
+ createTableIfNotExists(TOKENS_TABLE_NAME, databaseType.tokensTableSql());
Review Comment:
Not necessarily for this PR, but I wonder if executing these in a single
Statement execution might help minimize the potential for the "already exists"
error while improving efficiency slightly.
Issue Time Tracking
-------------------
Worklog Id: (was: 1005093)
Time Spent: 20m (was: 10m)
> Intermittent Postgres type already exists exception
> ---------------------------------------------------
>
> Key: KNOX-3252
> URL: https://issues.apache.org/jira/browse/KNOX-3252
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The issue is a race condition during table creation when multiple Knox
> instances are starting up simultaneously. At the initial "isTableExists"
> check the tables are not yet created. So Knox-instance-0 and Knox-instance-1
> will both go ahead with the creation. Postgres will create a record in
> pg_class and pg_type as well. However the process that gets there later will
> get the exception due to the record that was created by the other process in
> pg_type.
> I was able to reproduce it locally. I started up a local Knox instance and I
> had a Postgres db running on my docker desktop. I added a breakpoint to the
> table creation and created a new type called "knox_tokens" manually.
> {code:java}
> CREATE TYPE knox_tokens AS ENUM ('active', 'expired', 'revoked');{code}
> After this proceeding with the Knox process I got the exception. Solution is
> catching this exception validating the SQL state and skip table creation
> entirely in that Knox instance.
> {code:java}
> 2026-02-10 21:19:44,825 ERROR knox.gateway
> (TokenStateServiceFactory.java:createService(63)) - Error while
> initiatalizing
> org.apache.knox.gateway.services.token.impl.JDBCTokenStateService: Error
> while initiating JDBCTokenStateService: org.postgresql.util.PSQLException:
> ERROR: type "knox_tokens" already exists{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
