moresandeep commented on code in PR #1150:
URL: https://github.com/apache/knox/pull/1150#discussion_r2832767580
##########
.github/workflows/tests.yml:
##########
@@ -97,4 +97,4 @@ jobs:
- name: Tear Down Docker Compose
if: always()
- run: docker compose -f ./.github/workflows/compose/docker-compose.yml
down --volumes
+ run: docker compose -f ./.github/workflows/compose/docker-compose.yml
down --volumes --rmi all
Review Comment:
Shouldn't it delete only `apache/knox-dev:local-${GITHUB_RUN_ID:-local}`
image and not ALL? I think we might accidentally delete other working images or
if it fails then no image at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
