[ 
https://issues.apache.org/jira/browse/KNOX-3260?focusedWorklogId=1006687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1006687
 ]

ASF GitHub Bot logged work on KNOX-3260:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Feb/26 16:29
            Start Date: 23/Feb/26 16:29
    Worklog Time Spent: 10m 
      Work Description: lmccay commented on code in PR #1154:
URL: https://github.com/apache/knox/pull/1154#discussion_r2841815486


##########
gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/ClientIdAndClientSecretFederationFilterTest.java:
##########
@@ -76,6 +78,28 @@ public void testGetWireTokenUsingClientCredentialsFlow() 
throws Exception {
       assertEquals(passcode, wireToken.getRight());
     }
 
+    @Test
+    public void testGetWireTokenUsingClientCredentialsBasicAuth() throws 
Exception {

Review Comment:
   Since, I decoupled the two PRs, there aren't multiple tests here anymore. 
Let's follow up with this in a separate one. What do you think, @smolnar82 ?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1006687)
    Time Spent: 0.5h  (was: 20m)

> Extend Client Credentials Support to include the client_id and client_secret 
> as HTTP Basic
> ------------------------------------------------------------------------------------------
>
>                 Key: KNOX-3260
>                 URL: https://issues.apache.org/jira/browse/KNOX-3260
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: JWT
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>            Priority: Major
>             Fix For: 3.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Many OAuth clients for client credentials only support HTTP basic credentials 
> + grant_type headers.
> Extend the existing support for HTTP Basic that is there for passcode and 
> JWT's as passwords to support but client_id and client_secret when the 
> grant_type is also client_credentials.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to