smolnar82 commented on code in PR #1168:
URL: https://github.com/apache/knox/pull/1168#discussion_r2874515013
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/TokenAuthorityServiceMessages.java:
##########
@@ -20,14 +20,15 @@
import org.apache.knox.gateway.i18n.messages.Message;
import org.apache.knox.gateway.i18n.messages.MessageLevel;
import org.apache.knox.gateway.i18n.messages.Messages;
+import org.apache.knox.gateway.i18n.messages.StackTrace;
@Messages(logger = "org.apache.knox.gateway.services.token.state")
public interface TokenAuthorityServiceMessages {
@Message(level = MessageLevel.ERROR, text = "There was an error getting kid,
cause: {0}")
void errorGettingKid(String message);
@Message(level = MessageLevel.ERROR, text = "Failed to verify token using
JWKS endpoint {0}, reason: {1}")
- void jwksVerificationFailed(String jwksUrl, String reason);
+ void jwksVerificationFailed(String jwksUrl, String reason, @StackTrace(
level = MessageLevel.ERROR) Exception e);
Review Comment:
But this isn't a `printStackTrace`. It's a control over when to `log` the
stack (above certain log level, see details in
`org.apache.knox.gateway.i18n.messages.MessagesInvoker#findLoggableThrowable`).
I did a small test (changed the above JWKS URL to an invalid one). In
gateway.log, I can see it (that's why I added to be honest). However, neither
in gateway.out nor in gateway.err I saw anything...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
