hanicz commented on code in PR #1175:
URL: https://github.com/apache/knox/pull/1175#discussion_r2919026844
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -1363,6 +1365,17 @@ public String
getClouderaManagerServiceDiscoveryRoleFetchStrategy() {
return get(CLOUDERA_MANAGER_SERVICE_DISCOVERY_ROLE_FETCH_STRATEGY,
CLOUDERA_MANAGER_SERVICE_DISCOVERY_ROLE_FETCH_STRATEGY_BY_ROLE);
}
+ @Override
+ public Set<String> getClouderaManagerClientSSLProtocols() {
Review Comment:
Could you please add unit tests for this and
`getClouderaManagerClientSSLCiphers`. Its pretty straightforward. Everything
else looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
