[
https://issues.apache.org/jira/browse/KNOX-3276?focusedWorklogId=1009117&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1009117
]
ASF GitHub Bot logged work on KNOX-3276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/26 15:10
Start Date: 11/Mar/26 15:10
Worklog Time Spent: 10m
Work Description: hanicz commented on code in PR #1175:
URL: https://github.com/apache/knox/pull/1175#discussion_r2919026844
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -1363,6 +1365,17 @@ public String
getClouderaManagerServiceDiscoveryRoleFetchStrategy() {
return get(CLOUDERA_MANAGER_SERVICE_DISCOVERY_ROLE_FETCH_STRATEGY,
CLOUDERA_MANAGER_SERVICE_DISCOVERY_ROLE_FETCH_STRATEGY_BY_ROLE);
}
+ @Override
+ public Set<String> getClouderaManagerClientSSLProtocols() {
Review Comment:
Could you please add unit tests for this and
`getClouderaManagerClientSSLCiphers`. Its pretty straightforward. Everything
else looks good to me.
Issue Time Tracking
-------------------
Worklog Id: (was: 1009117)
Time Spent: 20m (was: 10m)
> Add new config that controls TLS settings in CM client
> ------------------------------------------------------
>
> Key: KNOX-3276
> URL: https://issues.apache.org/jira/browse/KNOX-3276
> Project: Apache Knox
> Issue Type: Task
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of today, Knox uses its own server-side TLS configuration in
> DiscoveryApiClient when it comes to configuring SSL between Knox and CM.
> However, this might not overlap and CM uses a separate set of TLS
> ciphers/protocols. To address that, we will need to add new configs to
> control the SSL settings within the CM API client.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
