sneethiraj opened a new pull request, #1197:
URL: https://github.com/apache/knox/pull/1197

   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   KNOX-3297: Docker entrypoint script has issues that prevents this image 
being run as docker container and as a pod in k8s
   
   ## What changes were proposed in this pull request?
   
   1. Modified to use keytool from the PATH instead of hardcoding it.
   2. Fixed a scripting error related to default init of MASTER_S... 
environment variable.
   3. Added additional validation for file existance before additing it to 
truststore. Also, introduced a custom env variable TRUSTSTORE_IMPORTS to allow 
customers to add more number of certificates into truststore.
   
   ## How was this patch tested?
   
   1. Validated the changes as standalone docker [run]
   2. Validated by running the docker image as k8s pod
   
   (Please explain how this patch was tested. For instance: running automated 
unit/integration tests, manual tests. Please write down your test steps as 
detailed as possible)
   
   ## Integration Tests
   no new integration tests.
   
   ## UI changes
   None.
   
   Please review [Knox Contributing 
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
 before opening a pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to