[
https://issues.apache.org/jira/browse/KNOX-3304?focusedWorklogId=1017018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1017018
]
ASF GitHub Bot logged work on KNOX-3304:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/26 10:08
Start Date: 23/Apr/26 10:08
Worklog Time Spent: 10m
Work Description: moresandeep commented on code in PR #1209:
URL: https://github.com/apache/knox/pull/1209#discussion_r3129989139
##########
gateway-docker/src/main/resources/docker/gateway-entrypoint.sh:
##########
@@ -183,14 +195,18 @@ fi
if [[ -n $CA_FILE ]] && [[ -f ${CA_FILE} ]]
then
echo "Creating truststore with provided CA certificate/s."
- importMultipleCerts "$CA_FILE"
+ if ! importMultipleCerts "$CA_FILE"; then
+ echo "WARN: Unable to import CA certs from [${CA_FILE}]. Continuing
startup..."
+ fi
fi
# Import custom certs one by one
if [[ -n $CUSTOM_CERT ]] && [[ -f ${CUSTOM_CERT} ]]
then
echo "Importing Custom certs."
- importMultipleCerts "$CUSTOM_CERT"
+ if ! importMultipleCerts "$CUSTOM_CERT"; then
+ echo "WARN: Unable to import custom certs from [${CUSTOM_CERT}].
Continuing startup..."
Review Comment:
True, but given we have silent failures the more the logging the better.
Also, this is just for the startup.
Specifically, line 206 and 208 tells me quickly which part of the code
failed. Startup logs go by quick so it helps to log more.
Issue Time Tracking
-------------------
Worklog Id: (was: 1017018)
Time Spent: 1h 40m (was: 1.5h)
> Support for Openshift/SCC
> -------------------------
>
> Key: KNOX-3304
> URL: https://issues.apache.org/jira/browse/KNOX-3304
> Project: Apache Knox
> Issue Type: Task
> Components: docker
> Affects Versions: 2.1.0
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Attachments:
> 0001-KNOX-3304-added-installation-of-curl-in-the-Docker.patch,
> 0002-KNOX-3304-fixed-import-of-letsencrupt-root-cert.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The current docker image that is generated does not work with Openshift and
> ECS platform due to restrictions imposed by the platforms. Specifically,
> there are two requirements
> # The helm chart that installs Knox image should use an arbitrary runAsUser
> # The helm chart should not have any runAsGroup and fsUser
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
