smolnar82 commented on PR #1215:
URL: https://github.com/apache/knox/pull/1215#issuecomment-4459776847
As part of this PR I modified the Docker-based test orchestration as well,
I'll update the `README.md` later on...
```
I have unified the Docker build process and streamlined the CI workflow.
Key Changes:
1. Unified Dockerfile: I've updated .github/workflows/build/Dockerfile to
be the single source of truth. It now handles the extraction of pre-built Knox
and KnoxShell tarballs from the target directory.
2. Simplified Docker Compose:
.github/workflows/compose/docker-compose.yml now uses the project root as its
context and points to the unified Dockerfile. I also removed the redundant
knox-dev-local service.
3. Cleaner CI Workflow: In .github/workflows/tests.yml, I removed the
manual "Extract Artifacts" step and the unnecessary environment variables
(KNOX_URL, BRANCH). The Docker build now directly consumes the artifacts
produced by the Maven
step.
4. Removed Redundancy: I deleted Dockerfile.local as it is no longer
needed.
The local workflow is now perfectly aligned with the CI:
1. Run mvn clean install -DskipTests -Ppackage (or similar) on your host.
2. Run docker compose build knox-dev in .github/workflows/compose/.
3. The Docker build will be extremely fast as it just copies and extracts
your local artifacts.
```
Cc. @moresandeep @hanicz (wrt.
[KNOX-3256](https://issues.apache.org/jira/browse/KNOX-3256))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
