smolnar82 commented on code in PR #1236:
URL: https://github.com/apache/knox/pull/1236#discussion_r3340119634
##########
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/shirorealm/KnoxLdapContextFactory.java:
##########
@@ -70,15 +69,12 @@ public void setSystemAuthenticationMechanism(String
systemAuthenticationMechanis
}
@Override
- public void setSystemPassword(final String systemPass) {
- if (StringUtils.isBlank(systemPass)) {
- return;
- }
-
+ public String getSystemPassword() {
+ final String systemPass = super.getSystemPassword();
final AliasService aliasService = getAliasService();
if (!aliasService.isAlias(systemPass)) {
Review Comment:
Fixed.
##########
gateway-server/src/main/resources/conf/gateway-site.xml:
##########
@@ -56,6 +56,12 @@ limitations under the License.
<description>Base DN for LDAP entries in the proxy server. Default is
dc=proxy,dc=com.</description>
</property>
+ <propery>
+ <name>gateway.ldap.recursive.group.resolution</name>
+ <value>false</value>
+ <desciption>Boolean value indicating whether recursive group
resolution ie enabled in KnoxLDAPService.</desciption>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
