[ 
https://issues.apache.org/jira/browse/KNOX-3328?focusedWorklogId=1023269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1023269
 ]

ASF GitHub Bot logged work on KNOX-3328:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/26 09:28
            Start Date: 02/Jun/26 09:28
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on code in PR #1236:
URL: https://github.com/apache/knox/pull/1236#discussion_r3340119634


##########
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/shirorealm/KnoxLdapContextFactory.java:
##########
@@ -70,15 +69,12 @@ public void setSystemAuthenticationMechanism(String 
systemAuthenticationMechanis
     }
 
     @Override
-    public void setSystemPassword(final String systemPass) {
-        if (StringUtils.isBlank(systemPass)) {
-            return;
-        }
-
+    public String getSystemPassword() {
+        final String systemPass = super.getSystemPassword();
         final AliasService aliasService = getAliasService();
 
         if (!aliasService.isAlias(systemPass)) {

Review Comment:
   Fixed.



##########
gateway-server/src/main/resources/conf/gateway-site.xml:
##########
@@ -56,6 +56,12 @@ limitations under the License.
         <description>Base DN for LDAP entries in the proxy server. Default is 
dc=proxy,dc=com.</description>
     </property>
 
+    <propery>
+        <name>gateway.ldap.recursive.group.resolution</name>
+        <value>false</value>
+        <desciption>Boolean value indicating whether recursive group 
resolution ie enabled in KnoxLDAPService.</desciption>

Review Comment:
   Fixed.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1023269)
    Time Spent: 5h  (was: 4h 50m)

> Support recursive group resolution in LDAP Proxy Service
> --------------------------------------------------------
>
>                 Key: KNOX-3328
>                 URL: https://issues.apache.org/jira/browse/KNOX-3328
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 3.0.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 3.0.0
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> The current Knox LDAP proxy implementation only supports direct group 
> memberships for users. When a client queries for a user's {{memberOf}} 
> attribute, Knox only returns the groups where the user is an explicit member, 
> ignoring any transitive or nested group memberships.
> Additionally, group entries themselves are not enriched with the {{memberOf}} 
> attribute, making it difficult for clients to walk the hierarchy manually.
> This task implements:
> # Recursive group resolution for both search-based and {{memberOf}}-based 
> lookups.
> # Strict cycle detection to prevent infinite loops in misconfigured LDAP 
> environments.
> # Configurable depth limits to prevent performance degradation.
> # Enrichment of group-type entries with the {{memberOf}} attribute, allowing 
> clients to see parent group memberships.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to