[
https://issues.apache.org/jira/browse/KNOX-3330?focusedWorklogId=1024047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1024047
]
ASF GitHub Bot logged work on KNOX-3330:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/26 10:00
Start Date: 08/Jun/26 10:00
Worklog Time Spent: 10m
Work Description: smolnar82 commented on PR #1240:
URL: https://github.com/apache/knox/pull/1240#issuecomment-4647676361
I also asked Gemini to focus on the test coverage. Here is the output. I
removed some of the items as they are irrelevant for now (I know you'll be
working on the "generalization" of the attributes to support not only
user/group related searches):
```
While the PR introduces good unit tests for the new components, several
critical areas remain under-tested or completely uncovered.
1. Missing Test Scenarios
* Partition ID Collisions: The logic interceptorName.replaceAll("\\s+",
"") is prone to collisions. There are no tests ensuring that providing names
like "My LDAP" and "MyLDAP" won't cause the server to fail during
initialization.
* Interceptor Ordering: The PR relies on the order of names in
`gateway.ldap.interceptor.names`. There are no tests verifying that putting
`duplicatefilter` before a backend interceptor correctly results in no
deduplication of backend results (confirming "sink" behavior).
2. Error Handling Resilience
* Partial Failures: If multiple backends are configured and one is
unreachable, the system's behavior is untested. Does the entire search fail, or
does it gracefully continue to the next interceptor?
```
Issue Time Tracking
-------------------
Worklog Id: (was: 1024047)
Time Spent: 2h 40m (was: 2.5h)
> Improve LDAP Proxy configurability for multiple LDAP backends
> -------------------------------------------------------------
>
> Key: KNOX-3330
> URL: https://issues.apache.org/jira/browse/KNOX-3330
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: David Han
> Assignee: David Han
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The Knox ldap proxy uses an interceptor to proxy search requests to a
> configured backend. This configuration is somewhat limiting in how the proxy
> can transform search results. Refactor to configure on the interceptor level
> instead of the backend level so that new types of interceptors can be easily
> added and multiple backends can be included.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
