hanicz commented on PR #1279: URL: https://github.com/apache/knox/pull/1279#issuecomment-4808000441
> Few things: > > 1. I added my observation regarding `secret.getData()` on the review the other two below are minor nits. > 2. in case of batch/bulk mode if `secret-a` succeeds and `secret-b` fails looks like secret-a’s alias will be persisted with no rollback, is this expected? > 3. I think we'll need a DOC jira for this :) @moresandeep 1. As explained in my response the seret is converted into data and base64 encoded so I think the solution is correct. Tested with both stringData and data. 2. I added a secret validation. 3. I'll open a DOC jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
