[
https://issues.apache.org/jira/browse/KNOX-3360?focusedWorklogId=1026987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1026987
]
ASF GitHub Bot logged work on KNOX-3360:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/26 08:48
Start Date: 26/Jun/26 08:48
Worklog Time Spent: 10m
Work Description: hanicz commented on PR #1279:
URL: https://github.com/apache/knox/pull/1279#issuecomment-4808000441
> Few things:
>
> 1. I added my observation regarding `secret.getData()` on the review the
other two below are minor nits.
> 2. in case of batch/bulk mode if `secret-a` succeeds and `secret-b` fails
looks like secret-a’s alias will be persisted with no rollback, is this
expected?
> 3. I think we'll need a DOC jira for this :)
@moresandeep
1. As explained in my response the seret is converted into data and base64
encoded so I think the solution is correct. Tested with both stringData and
data.
2. I added a secret validation.
3. I'll open a DOC jira.
Issue Time Tracking
-------------------
Worklog Id: (was: 1026987)
Time Spent: 1h (was: 50m)
> New KnoxCLI command to save alias from k8s secret
> -------------------------------------------------
>
> Key: KNOX-3360
> URL: https://issues.apache.org/jira/browse/KNOX-3360
> Project: Apache Knox
> Issue Type: New Feature
> Components: KnoxCLI
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
