smolnar82 commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4833374307
> @arunk-kumar Thank you for picking up this task.
>
> * Please rebase the changes you are 14 commits behind `master`.
> *
`gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts`
still has two `org.apache.hadoop` references please fix those.
Nice catch, @hanicz !
I also found a couple more references to the old package name:
```
$ git status
On branch review-pr-1263
nothing to commit, working tree clean
$ grep -R "org.apache.hadoop.gateway" ./*
./CHANGES: * [KNOX-1553] - Update documentation to reference
org.apache.knox instead of org.apache.hadoop.gateway
./build-tools/src/main/resources/build-tools/spotbugs-filter.xml: <Class
name="~org.apache.hadoop.gateway..*" />
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts:
'org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm');
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts:
'org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory');
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch-parameters.xml:
<classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch.xml:
<classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
"
\"main.ldapContextFactory\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\",\n"
+
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
"
\"main.ldapRealm\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\",\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
" main.ldapRealm:
org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
" main.ldapContextFactory:
org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
assertEquals(params.get("main.ldapRealm"),
"org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
assertEquals(params.get("main.ldapContextFactory"),
"org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java:
assertThat( dispatch.getClassName(),
is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java:
assertThat( dispatch.getClassName(),
is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt:
62. HADOOP-1504. Fix terminate-org.apache.hadoop-gateway script in contrib/ec2
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt:132.
HADOOP-1635. Remove hardcoded keypair name and fix
launch-org.apache.hadoop-gateway
./gateway-topology-hadoop-xml/src/test/resources/testDescriptor.xml:
authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/resources/testDelete.xml:
authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParserTest.java:
assertEquals("org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm",
authenticationProvider.getParams().get("main.ldapRealm"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
