[
https://issues.apache.org/jira/browse/KNOX-1608?focusedWorklogId=1027436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1027436
]
ASF GitHub Bot logged work on KNOX-1608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/26 13:56
Start Date: 29/Jun/26 13:56
Worklog Time Spent: 10m
Work Description: smolnar82 commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4833374307
> @arunk-kumar Thank you for picking up this task.
>
> * Please rebase the changes you are 14 commits behind `master`.
> *
`gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts`
still has two `org.apache.hadoop` references please fix those.
Nice catch, @hanicz !
I also found a couple more references to the old package name:
```
$ git status
On branch review-pr-1263
nothing to commit, working tree clean
$ grep -R "org.apache.hadoop.gateway" ./*
./CHANGES: * [KNOX-1553] - Update documentation to reference
org.apache.knox instead of org.apache.hadoop.gateway
./build-tools/src/main/resources/build-tools/spotbugs-filter.xml: <Class
name="~org.apache.hadoop.gateway..*" />
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts:
'org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm');
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts:
'org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory');
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch-parameters.xml:
<classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch.xml:
<classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
"
\"main.ldapContextFactory\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\",\n"
+
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
"
\"main.ldapRealm\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\",\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
" main.ldapRealm:
org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
" main.ldapContextFactory:
org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
assertEquals(params.get("main.ldapRealm"),
"org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java:
assertEquals(params.get("main.ldapContextFactory"),
"org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java:
assertThat( dispatch.getClassName(),
is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java:
assertThat( dispatch.getClassName(),
is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt:
62. HADOOP-1504. Fix terminate-org.apache.hadoop-gateway script in contrib/ec2
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt:132.
HADOOP-1635. Remove hardcoded keypair name and fix
launch-org.apache.hadoop-gateway
./gateway-topology-hadoop-xml/src/test/resources/testDescriptor.xml:
authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/resources/testDelete.xml:
authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParserTest.java:
assertEquals("org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm",
authenticationProvider.getParams().get("main.ldapRealm"));
```
Issue Time Tracking
-------------------
Worklog Id: (was: 1027436)
Time Spent: 0.5h (was: 20m)
> Remove gateway-adapter module
> -----------------------------
>
> Key: KNOX-1608
> URL: https://issues.apache.org/jira/browse/KNOX-1608
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Sandor Molnar
> Priority: Blocker
> Fix For: 3.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The gateway-adapter module was added in 1.0.0 for the rename from
> org.apache.hadoop.gateway to org.apache.knox.gateway. We should remove this
> in 2.0.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
