[ 
https://issues.apache.org/jira/browse/KNOX-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105238#comment-18105238
 ] 

ASF subversion and git services commented on KNOX-3188:
-------------------------------------------------------

Commit d1c9e0135412dab5e005ceb91d3d88fd0acd561d in knox's branch 
refs/heads/v2.1.x from hanicz
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=d1c9e0135 ]

Knox security picks into v2.1.x (#1352)

* KNOX-3188 - Token renewal and revocation should be authorized based on the 
group membership of the authenticated subject. (#1083)

(cherry picked from commit 72be9fbd53a9b19483f683025155b665011d7243)

* KNOX-3410: KnoxToken enable/disable endpoints perform no caller autho… (#1343)

* KNOX-3410: KnoxToken enable/disable endpoints perform no caller authorization

* KNOX-3410: Address review comments

(cherry picked from commit f2126008ab764003e9831e48d30302886be93496)

* KNOX-3411: KnoxToken getUserTokens returns every user's token metadat… (#1344)

* KNOX-3411: KnoxToken getUserTokens returns every user's token metadata 
without a caller authorization check

* KNOX-3411: Add test clean-up

(cherry picked from commit 049dc0cb894f907efa920a1a2c10fb6ed56fb109)

* KNOX-3416: KnoxSSO redirects to untrusted site (#1346)

* KNOX-3416: KnoxSSO redirects to untrusted site

* KNOX-3416: Clarify error message for userInfo

(cherry picked from commit c3dee56346cfb2670a114d478db0ba2b51aa01f7)

* KNOX-3417: KnoxLdapRealm builds the LDAP search filter from the client 
username without RFC-4515 escaping (#1348)

(cherry picked from commit 3cb8ef745c44b39377d855d835198de183a4cef3)

* KNOX-3413: KnoxToken passcode verification accepts a valid passcode for a 
different token (#1345)

(cherry picked from commit 5342483a2c7ff229d8819d7df479980753640fc1)

* KNOX-3413: Fix unit test

* KNOX-3418: Path traversal → arbitrary file write/overwrite in the Apache Knox 
Admin API (#1349)

(cherry picked from commit de71a60cdf34c842abb8a49f770a0e33fe33c7e9)

* KNOX-3418: Fix jdk17 -> jdk11 compilation fails

---------

Co-authored-by: Sandor Molnar <[email protected]>

> Add group-based configuration parameter for KnoxToken renewer/revoker access 
> control
> ------------------------------------------------------------------------------------
>
>                 Key: KNOX-3188
>                 URL: https://issues.apache.org/jira/browse/KNOX-3188
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 2.0.0, 1.6.0, 2.1.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 3.0.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, the {{knox.token.renewer.whitelist}} parameter allows 
> administrators to specify a comma-separated list of users who are authorized 
> to invoke KnoxToken renewal and revocation APIs. While this works for 
> individual users, it does not provide a convenient way to manage 
> authorization at the group level.
> In environments where user/group membership is centrally managed (e.g., via 
> LDAP, AD, or other identity providers), group-based access control is often 
> preferred to simplify configuration and ongoing maintenance. Without group 
> support, administrators must list each individual user explicitly, which 
> becomes cumbersome and error-prone, especially in larger deployments.
> {*}Proposal{*}:
> Introduce a new optional configuration parameter (e.g., 
> {{{}knox.token.renewer.group.whitelist{}}}) that accepts a comma-separated 
> list of groups. Any user belonging to one of the listed groups should be 
> authorized to renew or revoke tokens.
> {*}Example{*}:
> {code:java}
> knox.token.renewer.whitelist=alice,bob  
> knox.token.renewer.group.whitelist=admins,devops
> {code}
>  In the above example, both explicitly whitelisted users ({{{}alice{}}}, 
> {{{}bob{}}}) and any users belonging to the {{admins}} or {{devops}} groups 
> would be allowed to invoke the renewal/revocation APIs.
> {*}Benefits{*}:
>  * Simplifies administration by allowing group-based access control.
>  * Reduces the risk of configuration drift when onboarding or offboarding 
> users.
>  * Aligns KnoxToken access control with common enterprise practices for 
> authorization management.
> {*}Acceptance Criteria{*}:
>  * A new configuration parameter {{knox.token.renewer.group.whitelist}} is 
> recognized.
>  * Token renewal/revocation APIs check both user and group whitelists for 
> authorization.
>  * Backwards compatibility: existing behavior with 
> {{knox.token.renewer.whitelist}} remains unchanged if the group-based 
> parameter is not set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to