[ 
https://issues.apache.org/jira/browse/KNOX-3421?focusedWorklogId=1037041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1037041
 ]

ASF GitHub Bot logged work on KNOX-3421:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Aug/26 13:41
            Start Date: 21/Aug/26 13:41
    Worklog Time Spent: 10m 
      Work Description: moresandeep commented on code in PR #1353:
URL: https://github.com/apache/knox/pull/1353#discussion_r3830663661


##########
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/shirorealm/KnoxLdapRealm.java:
##########
@@ -762,8 +769,10 @@ private static String expandTemplate( final String 
template, final Matcher input
       String lookupValue = input.group( lookupIndex );
       if (lookupValue == null) {
           lookupValue = "";
-      } else if (escapeForLdapFilter) {
+      } else if (escapeMode == EscapeMode.FILTER) {
           lookupValue = escapeLdapSearchFilterValue(lookupValue);
+      } else if (escapeMode == EscapeMode.DN) {
+          lookupValue = escapeDnValue(lookupValue);

Review Comment:
   Agreed, this is indeed an issue :( I'll followup with a patch!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1037041)
    Time Spent: 1h  (was: 50m)

> Upgrade Shiro to 2.2.1
> ----------------------
>
>                 Key: KNOX-3421
>                 URL: https://issues.apache.org/jira/browse/KNOX-3421
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Housekeeping upgrades to a maintained version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to