hanicz commented on code in PR #1355:
URL: https://github.com/apache/knox/pull/1355#discussion_r3850509744


##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/backend/LdapProxyBackend.java:
##########
@@ -887,6 +892,11 @@ protected List<Entry> performPagedSearch(LdapConnection 
connection, String baseD
                 }
                 if (cursor.isDone()) {
                     SearchResultDone done = cursor.getSearchResultDone();
+
+                    LdapResult ldapResult = done.getLdapResult();

Review Comment:
   `SearchResultDone done` can be null at this point due to errors. The 
`isDone()` docs don't mention its relation with `getSearchResultDone()` so this 
might be a genuine concern here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to