smolnar82 opened a new pull request, #1367: URL: https://github.com/apache/knox/pull/1367
[KNOX-3428](https://issues.apache.org/jira/browse/KNOX-3428) - Bump Spring to 6.2.19 and add HashiCorp Vault alias-service integration tests ## What changes were proposed in this pull request? - Bumped spring.version to 6.2.19 (from 6.2.11) in pom.xml. - Added a Docker-based integration suite exercising Knox's HashiCorp Vault remote alias service end-to-end, as a safety net for the Spring / Spring Vault bump. Under .github/workflows: - `tests/test_knox_hashicorp_vault_alias.py`: round-trips an alias through the admin alias REST API and verifies the secret directly in Vault, plus delete-removal and an unauthenticated-401 check. - `compose/docker-compose.hashicorp-vault.yml` + `compose/hashicorp-vault/{gateway-site,admin}.xml`: dev-mode Vault (hashicorp/vault:1.17) and Knox on a Vault-backed RemoteAliasService. gateway-site.xml also sets `gateway.service.tokenstate.impl=DefaultTokenStateService` to avoid an init-time alias read that would make Vault a fatal startup dependency. - `compose/docker-compose.yml + tests.yml`: base run ignores the suite; CI runs it and uploads test-results-hashicorp-vault.xml. ## How was this patch tested? Ran the suite locally via Docker Compose (`up -d knox vault` → `run --rm tests pytest -v test_knox_hashicorp_vault_alias.py`): 3 passed. `test_alias_write_is_stored_in_vault` reads the secret straight from Vault's HTTP API and asserts the exact value, confirming the write reached Vault (not just the local keystore fallback). `pylint *.py` rated 10.00/10. ## Integration Tests Added `test_knox_hashicorp_vault_alias.py`. The Vault dev image boots in seconds, so it runs on every PR (not label-gated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
