smolnar82 opened a new pull request, #1368: URL: https://github.com/apache/knox/pull/1368
[KNOX-3429](https://issues.apache.org/jira/browse/KNOX-3429) - Harden source assembly to exclude build caches, runtime state, and staging dir ## What changes were proposed in this pull request? `src/assembly.xml` includes `**` from the repo root and excluded only `target/`, `node_modules/`, and `IDE files`. Since it snapshots the working tree at end-of-build, leftover artifacts get bundled into `knox-<version>-src.zip` - bloating it (staging then fails with `svn E175002` on the `dist` repo) and shipping generated `keystores/credentials` in a source release. Adds scoped excludes: - .angular/.scannerwork caches - candidate/** (re-bundled a previous *-src.zip) - runtime state outside target/ (data/{security,ldap-server,deployments}, logs, *.pid) - and JVM crash/heap dumps. Kept narrow (**/logs/*.log not **/*.log) to drop no tracked source. Safety net only - staging from a clean checkout remains recommended. How was this patch tested? ``` - xmllint --noout src/assembly.xml passes. - git ls-files confirms no new pattern matches tracked source (preserves home/data/**/README, home/logs/.gitignore, sample .log). - Clean-checkout build already yields the correct ~38 MB zip; excludes now make a dirty tree produce the same. ``` Integration Tests N/A UI changes N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
