smolnar82 commented on code in PR #1372:
URL: https://github.com/apache/knox/pull/1372#discussion_r3915215529
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/interceptor/UserSearchInterceptor.java:
##########
@@ -71,6 +75,7 @@ public Entry lookup(LookupOperationContext ctx) throws
LdapException {
entry = backend.getUser(username, schemaManager);
} catch (Exception e) {
LOG.ldapLookupFailed(ctx.getDn().toString(),e);
+ throw new LdapOperationException(ResultCodeEnum.OTHER,
"Lookup request to backend " + getName() + " failed.", e);
Review Comment:
The only comment I have is if we can somehow get the original backend result
code and use it here other than `OTHER`. I'm not sure about this, so raising it
as a question and would not block the merge of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
