[
https://issues.apache.org/jira/browse/KNOX-3426?focusedWorklogId=1039415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1039415
]
ASF GitHub Bot logged work on KNOX-3426:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/26 12:35
Start Date: 03/Sep/26 12:35
Worklog Time Spent: 10m
Work Description: smolnar82 commented on PR #1374:
URL: https://github.com/apache/knox/pull/1374#issuecomment-5525842786
Thanks for the review discussion, @hanicz . Summarizing what we agreed so
it's on the record:
This PR (now):
- Fix `removeLicenceHeader` to strip only `--` comment lines instead of
cutting everything before the first `CREATE TABLE`. This removes SQL from
nothing, so the Postgres `pg_advisory_lock(...)` statements survive. Addressing
the fragility flagged in review while keeping the current parsing approach.
- Merge as-is once that's in.
Why not the fuller refactor yet: moving table creation to a pure SQL layer
(DB-level `CREATE TABLE IF NOT EXISTS`, no Java-side splitting/guard) is
blocked by two engines:
- Oracle: no `IF NOT EXISTS`, but solvable purely in SQL by wrapping the
DDL in a PL/SQL block in the Oracle files.
- Derby: no `IF NOT EXISTS` and can't execute a multi-statement script in
one call; it's the one that forces the Java splitting. Derby is slated to be
dropped.
Follow-up (separate JIRA, after
[KNOX-3401](https://issues.apache.org/jira/browse/KNOX-3401) and once Derby is
removed): switch to the pure SQL layer (Oracle handled via PL/SQL, everyone
else via IF NOT EXISTS) and delete the Java-side parsing/splitting entirely.
I'll file the JIRA to track this.
Issue Time Tracking
-------------------
Worklog Id: (was: 1039415)
Time Spent: 4.5h (was: 4h 20m)
> Delegation policy schema and JDBC implementation
> ------------------------------------------------
>
> Key: KNOX-3426
> URL: https://issues.apache.org/jira/browse/KNOX-3426
> Project: Apache Knox
> Issue Type: Task
> Components: JWT
> Reporter: Harrison Sheinblatt
> Assignee: Harrison Sheinblatt
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Persistent storage for delegation policies, with a service interface and JDBC
> implementation. After these tasks, delegation policies can be stored and
> retrieved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
