[
https://issues.apache.org/jira/browse/KNOX-3432?focusedWorklogId=1039487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1039487
]
ASF GitHub Bot logged work on KNOX-3432:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/26 16:08
Start Date: 03/Sep/26 16:08
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on PR #1376:
URL: https://github.com/apache/knox/pull/1376#issuecomment-5528545404
## Test Results
4 files 4 suites 16s ⏱️
84 tests 84 ✅ 0 💤 0 ❌
102 runs 102 ✅ 0 💤 0 ❌
Results for commit b13d4a60.
[test-results]:data:application/gzip;base64,H4sIAGSbmWoC/13MSw6DIBSF4a0Yxh3wFOxmGrxAQqrS8BiZ7r1o1NIOv/8kZ0XOTzahe8dvHUrF5wumRJ19WCpJX12XvG2Kn3ikAvBXnv5VC76C0376CTbGEI8Sy7I9EkwPnI9t+T7ubg53t38Q5tnnCjQSZrjusRyZcYJL4IPAGAYlBeMUFBBLBdUavT8YNsSdAgEAAA==
Issue Time Tracking
-------------------
Worklog Id: (was: 1039487)
Time Spent: 20m (was: 10m)
> In knoxidf, advertise token exchange in grant_types_supported
> -------------------------------------------------------------
>
> Key: KNOX-3432
> URL: https://issues.apache.org/jira/browse/KNOX-3432
> Project: Apache Knox
> Issue Type: Task
> Reporter: Harrison Sheinblatt
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> RFC 8693 defines the grant type for token exchange,
> urn:ietf:params:oauth:grant-type:token-exchange, in section 2.1. RFC 8414
> defines the grant_types_supported fields in the metadata in section 2.
> Knoxidf currently sets this value in
> gateway-service-knoxidf/src/main/java/org/apache/knox/gateway/service/knoxidf/DiscoveryResource.java
> as
> ```
> config.put("grant_types_supported", new String[]\{KnoxIDFConstants.AUTH_CODE,
> KnoxIDFConstants.REFRESH_TOKEN});
> ```
> It does not list token exchange, and hence a reader of the metadata would
> believe that knoxidf does not support it, based on the spec.
> Given knoxidf does support it, the token exchange type should be added there.
> The value to add is "urn:ietf:params:oauth:grant-type:token-exchange".
> RFC 6749 §4.5 (Extension Grants) explains that extension grants need the full
> name, not the short name. RFC 8693 §2.1 defines the constant to use. It's
> registered in IANA OAuth Parameters registry. RFC 8414 §2 says the field is
> "a list of the OAuth 2.0 grant type values that this authorization server
> supports" — i.e., the same values used in the grant_type request parameter.
> The value is already in a constant in JWTFederationFilter. We must decide to
> duplicate it in KnoxIDFConstants for use here or reuse the constant. It's
> probably best to duplicate it – it's a standard so won't likely change.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
