moresandeep commented on PR #1388: URL: https://github.com/apache/knox/pull/1388#issuecomment-5685021203
I checked out the PR, did a complete build, created a docker image and verified the following items: 1. Port mapping feature as this depends heavily on servlet and adapters 2. WebSocket with Zeppelin docker container (older but i am only testsing WS) 3. WebShell - Ran into some issues (missing libutil.so) BUT this is not related to this feature, i need to investigate this further. Overall I think the PR is stable. I should note that I did not do a visual code inspection, this is feature testing! SO, looks good 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
