hanicz opened a new pull request, #1455: URL: https://github.com/apache/knox/pull/1455
[KNOX-3514](https://issues.apache.org/jira/browse/KNOX-3514) - Make favicon and page title theme bound as well ## What changes were proposed in this pull request? Make favicon and page title theme-bound on knoxauth login/logout pages The knoxauth themes only swapped CSS, so themed login and logout pages still showed the default Knox favicon and "KnoxSSO" title in the browser tab. This adds an optional `KNOX_THEME_BRANDING` map in `theme-config.js`, keyed by theme name, where each theme can set a title brand (replaces "KnoxSSO") and a favicon path. `knox-theme.js` applies them as the page head loads, so there's no flash of the old title/favicon. Themes without an entry keep the Knox defaults. The bundled modern theme now shows "Apache Knox SSO - Sign In" / "Apache Knox SSO - Session Termination" and a new SVG favicon. ## How was this patch tested? Tested locally the modern and default themes ## UI changes <img width="1919" height="968" alt="Screenshot 2026-10-14 at 8 17 16" src="https://github.com/user-attachments/assets/f5eb5c8c-d176-41c2-bcbe-7ef0a44c8c4d"; /> <img width="1909" height="962" alt="Screenshot 2026-10-14 at 8 17 34" src="https://github.com/user-attachments/assets/e946d72e-8e60-4aca-960f-95d36f347b0e"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
