[ 
https://issues.apache.org/jira/browse/KNOX-3532?focusedWorklogId=1051877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1051877
 ]

ASF GitHub Bot logged work on KNOX-3532:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Nov/26 13:50
            Start Date: 02/Nov/26 13:50
    Worklog Time Spent: 10m 
      Work Description: bonampak commented on code in PR #1472:
URL: https://github.com/apache/knox/pull/1472#discussion_r4443159925


##########
gateway-applications/src/main/resources/applications/knoxauth/app/js/knoxauth.js:
##########
@@ -27,6 +27,11 @@ function get(name) {
        }
 }
 
+function getOriginalUrl() {
+       var originalUrl = get("originalUrl");
+       return originalUrl ? originalUrl.replace(/&theme=[a-zA-Z0-9_-]{1,64}$/, 
"") : originalUrl;

Review Comment:
   this pattern is the same as KNOX_THEME_NAME_PATTERN. 
   You can add the same comment as in logout.jsp:
   ```
   // Keep pattern in sync with KNOX_THEME_NAME_PATTERN in theme-config.js
   ```





Issue Time Tracking
-------------------

            Worklog Id:     (was: 1051877)
    Remaining Estimate: 0h
            Time Spent: 10m

> KnoxSSO login page redirects to a broken URL when the theme param comes after 
> originalUrl
> -----------------------------------------------------------------------------------------
>
>                 Key: KNOX-3532
>                 URL: https://issues.apache.org/jira/browse/KNOX-3532
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Homepage, KnoxSSO
>    Affects Versions: 3.0.0
>            Reporter: Tamás Hanicz
>            Assignee: Tamás Hanicz
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When the login page is opened with the theme parameter after originalUrl, the 
> post-login redirect URL includes &theme=<name>, which usually results in a 
> 404.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to