smolnar82 commented on code in PR #1479:
URL: https://github.com/apache/knox/pull/1479#discussion_r4464911732
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/KnoxLDAPServerManager.java:
##########
@@ -211,6 +211,11 @@ private void createInterceptors(GatewayConfig config)
throws Exception {
}
}
+ // Add common LDAP Proxy configurations to the roles lookup
interceptor
Review Comment:
Ok, you are the 2nd reviewer pointing this out (@hanicz reached out to me
directly with a similar comment), so I'm going to move them (the settings only
control the interceptor; the roles lookup service never reads them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
