handavid commented on code in PR #1475:
URL: https://github.com/apache/knox/pull/1475#discussion_r4476586799


##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/backend/LdapProxyBackend.java:
##########
@@ -566,7 +567,7 @@ public List<Entry> searchUsers(String filter, SchemaManager 
schemaManager) throw
     }
 
     @Override
-    public List<Entry> search(String searchBase, SearchScope searchScope, 
String filter, SchemaManager schemaManager) throws Exception {
+    public List<Entry> search(String searchBase, SearchScope searchScope, 
String filter, SchemaManager schemaManager, String[] attributes) throws 
Exception {

Review Comment:
   I changed the behavior to match null/empty --> *



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to