[
https://issues.apache.org/jira/browse/KNOX-3539?focusedWorklogId=1052368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1052368
]
ASF GitHub Bot logged work on KNOX-3539:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/26 07:52
Start Date: 04/Nov/26 07:52
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1479:
URL: https://github.com/apache/knox/pull/1479#discussion_r4465003102
##########
.github/workflows/tests/test_knox_ldap_proxy_search_with_role_lookup.py:
##########
@@ -163,6 +169,11 @@ def test_list_all_roles_by_objectclass_presence(self) ->
None:
groups = self.rdn_values(self.search(PROXY_GROUPS_BASE,
"(objectClass=*)"))
self.assertEqual(ALL_ROLES, set(groups))
+ # ApacheDS hands the interceptors
(|(objectClass=groupOfNames)(objectClass=referral)), which
+ # the roles lookup does not take for a list search from an ancestor of
ou=groups. So the
+ # backend groups are translated instead and roles assigned only to users
(platform:deployer)
+ # are missing.
+ @unittest.skip("root-level role listing misses roles assigned only to
users")
Review Comment:
I filed KNOX-3546; feel free to comment on the JIRA. I added explanation in
the PR description here too.
Issue Time Tracking
-------------------
Worklog Id: (was: 1052368)
Time Spent: 1h (was: 50m)
> Add an option to lowercase the user ID in the LDAP proxy roles-lookup
> interceptor
> ---------------------------------------------------------------------------------
>
> Key: KNOX-3539
> URL: https://issues.apache.org/jira/browse/KNOX-3539
> Project: Apache Knox
> Issue Type: Task
> Components: LDAP, Server
> Affects Versions: 3.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The LDAP proxy's {{LDAPRolesLookupInterceptor}} builds the user ID for the
> roles lookup from the {{uid}} attribute of the entry returned by the backend
> directory. For Active Directory backends, uid holds {{sAMAccountName}}. AD
> matches this attribute case-insensitively, but the value comes back in its
> canonical case (e.g. {{Admin}}). Whatever case the client searched with
> ({{admin}}, {{ADMIN}}), the roles-lookup service receives {{Admin}}.
> If the roles backend stores and matches user IDs case-sensitively and has
> role memberships keyed on a different case (e.g. the login name as typed),
> the lookup finds nothing and the user gets no roles.
> *Proposal*: add a new gateway configuration property:
> {code}
> gateway.ldap.roles.lookup.lowercase.user.id = false (default)
> {code}
> When {{true}}, the interceptor lowercases the user ID before calling
> {{LDAPRolesLookupService.lookupRoles()}}. Combined with
> {{expression.principal.mapping = (lowercase username)}} in the
> {{identity-assertion}} provider, the asserted principal and the roles-lookup
> key are then always the same case. The default (false) keeps the current
> behavior.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
