smolnar82 opened a new pull request, #1505: URL: https://github.com/apache/knox/pull/1505
[KNOX-3564](https://issues.apache.org/jira/browse/KNOX-3564) - Increase DELEGATION_POLICY_USERS.username column size to 2048 to support SPIFFE IDs ## What changes were proposed in this pull request? The SPIFFE specification allows SPIFFE IDs of up to 2048 bytes ([SPIFFE ID spec, section 2.3](https://spiffe.io/docs/latest/spiffe-specs/spiffe-id/#23-maximum-spiffe-id-length)), but `DELEGATION_POLICY_USERS.username` was `VARCHAR(1023)`, so longer SPIFFE IDs could not be stored as permitted users on a delegation policy. - `createKnoxIDFDelegationPolicyTables.sql`: `DELEGATION_POLICY_USERS.username` changed from `VARCHAR(1023)` to `VARCHAR(2048)` - `createKnoxIDFDelegationPolicyTablesOracle.sql`: `DELEGATION_POLICY_USERS.username` changed from `VARCHAR2(1023)` to `VARCHAR2(2048)` This also aligns the column with `DELEGATION_POLICIES.actor_id`, which is already 2048. ## How was this patch tested? - Added `DelegationPolicySchemaTest.testUsernameAcceptsMaxLengthSpiffeId`, which stores and reads back a 2048-character SPIFFE ID in `DELEGATION_POLICY_USERS` (H2) and verifies that a 2049-character value is rejected - Ran `DelegationPolicySchemaTest` and `JdbcDelegationPolicyServiceTest`: all tests pass ## Integration Tests No integration test was added: this is a schema column size change, covered by the unit test above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
