smolnar82 opened a new pull request, #1507:
URL: https://github.com/apache/knox/pull/1507

   [KNOX-3565](https://issues.apache.org/jira/browse/KNOX-3565) - Exclude 
snappy-java from hadoop-common
   
   ## What changes were proposed in this pull request?
   
   hadoop-common 3.4.1 transitively pulled 
`org.xerial.snappy:snappy-java:1.1.10.4` into almost every module at compile 
scope. Knox doesn't use Hadoop compression codecs, so this PR removes it:
   - Excludes snappy-java from the managed `hadoop-common` dependency in the 
root pom.
   - Excludes it from the `hadoop-common` test-jar in `gateway-test-release`, 
which dependencyManagement doesn't cover.
   - Adds `org.xerial.snappy:snappy-java` to the enforcer's 
`bannedDependencies` so it can't come back through another dependency.
   
   ## How was this patch tested?
   
   - `mvn dependency:tree -Dincludes=org.xerial.snappy:snappy-java` finds 
nothing in any module.
   - `mvn validate` passes with the new enforcer ban.
   - Unit tests pass for `gateway-spi`, `gateway-topology-hadoop-xml`, 
`gateway-provider-identity-assertion-hadoop-groups` and 
`gateway-provider-security-hadoopauth`.
   
   ## Integration Tests
   
   No integration tests were added or changed; this is a dependency-only 
change. The existing CI suites cover the runtime behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to