bonampak commented on code in PR #1497:
URL: https://github.com/apache/knox/pull/1497#discussion_r4541081922
##########
gateway-provider-rewrite-common/src/main/java/org/apache/knox/gateway/filter/rewrite/impl/UrlRewriteFilterApplyDescriptorImpl.java:
##########
@@ -44,4 +45,23 @@ public String getRule() {
return rule;
}
+ @Override
+ public boolean find() {
+ return find;
+ }
+
+ @Override
+ public UrlRewriteFilterApplyDescriptor find( boolean find ) {
+ this.find = find;
+ return this;
+ }
+
+ public void setFind( boolean find ) {
Review Comment:
With the rename to match="partial|whole", the attribute is an enum parsed
via `Enum.valueOf`, so an invalid value like `match="parttial"` now fails the
rules load instead of silently falling back (same as an invalid flow). This is
covered by `testLoadApplyInvalidMatch`.
A misspelled attribute name is still ignored, but that's Digester's
SetPropertiesRule default for every `rewrite.xml` attribute, so I'd leave it
out of this ticket.
The test revealed that the digester is not cleared after failure, so if a
subsequent load() invocations could fail. I'd keep that as a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
