lmccay commented on code in PR #1511:
URL: https://github.com/apache/knox/pull/1511#discussion_r4551662587


##########
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/K8sDestinationAudienceValidator.java:
##########
@@ -695,6 +704,22 @@ private Optional<String> pathFromHeader(final 
HttpServletRequest request) {
     return AudienceResource.normalizeAndTidy(rawPath);
   }
 
+  // Raw header values, so that even a value that fails to parse is recorded.

Review Comment:
   This could use some more comments, I think. There is some business logic 
here based on whether a path header exists or not and when it doesn't to fall 
back to requestURI. I think this could use some description of intent for 
overall understanding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to