Alright, sounds fair. Are these issues being actively worked on at the moment by you/Dan? Would like to get a new RC out ASAP.
-Todd On Fri, Mar 10, 2017 at 4:51 PM, Adar Dembo <[email protected]> wrote: > -1 > > env_util-test.cc and env-test.cc both fail to compile on Ubuntu 16.04 > with the default gcc (5.4.0). The errors look like this: > > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc: In lambda function: > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc:65:71: error: > label ‘gtest_label_testnofatal_67’ used but not defined > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc:65:108: warning: > label ‘gtest_label_testnofatal_73’ defined but not used > [-Wunused-label] > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc: In member > function ‘virtual void > kudu::env_util::EnvUtilTest_TestDiskSpaceCheck_Test::TestBody()’: > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc:65:71: error: > label ‘gtest_label_testnofatal_71’ used but not defined > /tmp/apache-kudu-1.3.0/src/kudu/util/env_util-test.cc:65:108: warning: > label ‘gtest_label_testnofatal_73’ defined but not used > [-Wunused-label] > src/kudu/util/CMakeFiles/env_util-test.dir/build.make:62: recipe for > target 'src/kudu/util/CMakeFiles/env_util-test.dir/env_util-test.cc.o' > failed > > I realize this is just test code, but AFAIK we have yet to ship a > release whose default build configuration (i.e. without NO_TESTS=1) > fails to build on a commonly used platform, and I'd like to avoid > setting that precedent. Between this and the macOS build breakages Dan > pointed out, I think we have enough reason to do an RC1 that builds > properly. > > On Fri, Mar 10, 2017 at 6:00 PM, Dan Burkert <[email protected]> > wrote: > > +0 > > > > - env_util-test.cc fails to build on OS X 10.10 (fixed on master in > 97831ead > > <https://github.com/apache/kudu/commit/97831ead>) > > - external_mini_cluster-test and security-itest fail on OS X 10.10 (fixed > > on master in c5ec0ddb0 > > <https://github.com/apache/kudu/commit/c5ec0ddb01da87de4a037a4879a4ef > 92c434930f> > > ) > > - verified signature > > > > I don't think we should hold the release over macOS test issues, but if > we > > end up needing to sink it for another reason we should backport those two > > patches. > > > > - Dan > > > > On Thu, Mar 9, 2017 at 10:37 PM, Todd Lipcon <[email protected]> wrote: > > > >> On Thu, Mar 9, 2017 at 10:36 PM, Todd Lipcon <[email protected]> wrote: > >> > >> > Hi, > >> > > >> > The Apache Kudu team is happy to announce the first release candidate > for > >> > Apache Kudu 1.3.0. > >> > > >> > Apache Kudu 1.3 is a minor release which adds various new features, > >> > improvements, bug fixes, and optimizations on top of Kudu 1.2. > Highlights > >> > include significantly improved support for security, garbage > collection > >> of > >> > historical data, and lower space consumption in default > configurations. > >> > Please see the release notes for details. > >> > > >> > Thanks to the 25 developers who contributed code or documentation to > this > >> > release! > >> > > >> > The is a source-only release. The artifacts were staged here: > >> > https://dist.apache.org/repos/dist/dev/kudu/1.3.0-RC1/ > >> > > >> > Java convenience binaries in the form of a Maven repository are staged > >> > here: > >> > https://repository.apache.org/content/repositories/ > orgapachekudu-1008/ > >> > > >> > It was built from this tag: > >> > https://git-wip-us.apache.org/repos/asf?p=kudu.git;a=commit;h= > >> > dfd9b491f635a89b75889f8277316c9b78143883 > >> > > >> > The release notes can be found here (some links from this document > will > >> > only work when this version is released): > >> > *https://github.com/apache/kudu/blob/branch-1.3.x/docs/relea > >> se_notes.adoc > >> > <https://github.com/apache/kudu/blob/branch-1.3.x/docs/relea > >> se_notes.adoc>* > >> > > >> > KEYS file: > >> > http://www.apache.org/dist/kudu/KEYS > >> > > >> > I'd suggest going through the README, building Kudu, and running the > >> > unit tests. Testing out the Maven repo would also be appreciated. > >> > > >> > The vote will run until Monday, 3/12 at 11PM PST. This is a bit more > than > >> > the minimum 72 hours, but given the weekend, I figured it's worth > giving > >> > two full business days for people to vote. > >> > > >> Oops, just noticed the typo right after sending. This should read > Monday, > >> 3/13 at 11pm PST. > >> > >> -Todd > >> > -- Todd Lipcon Software Engineer, Cloudera
