OK I'm going to sink this in favor of RC2. Thanks for the thorough investigation, Mike.
- Dan On Fri, Sep 1, 2017 at 2:40 PM, Mike Percy <[email protected]> wrote: > -1 on 1.5.0-RC1 for licensing reasons. > > I ran this command to look at the new files added between tags: > git diff --name-status 1.4.0 1.5.0-RC1 | grep ^A > > Then I grepped those changed files for ASF license headers. Of the ones > that didn't have the usual ASF license headers, I looked for a mention of > them in LICENSE.txt > > 1. The following files are missing from LICENSE.txt and need to be added. > We can just add an entry for the whole directory, I think: > > build-support/iwyu/iwyu_tool.py: LLVM Release License (only > thirdparty/llvm-* is mentioned as being covered by this license in the > thirdparty/LICENSE.txt file) > build-support/iwyu/mappings/boost-all-private.imp: LLVM Release License > build-support/iwyu/mappings/boost-all.imp: LLVM Release License > > We can simply say the files in build-support/iwyu/ are licensed under the > LLVM Release License, a full copy of which can be found in > thirdparty/LICENSE.txt > > 2. The license header for these files is wrong: > > java/kudu-client-tools/src/main/java/org/apache/kudu/ > mapreduce/tools/ExportCsv.java > java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ > ExportCsvMapper.java > java/kudu-client-tools/src/main/java/org/apache/kudu/ > mapreduce/tools/ImportParquet.java > java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ > ImportParquetMapper.java > java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ > ParquetReadSupport.java > java/kudu-client/src/test/java/org/apache/kudu/client/ > TestAuthnTokenReacquire.java > java/kudu-client/src/test/java/org/apache/kudu/client/ > TestAuthnTokenReacquireOpen.java > > They are using the ASL2.0 "short header" but because this is an ASF project > they need to use the standard ASF header [1] that starts with: > "// Licensed to the Apache Software Foundation (ASF) under one or more > contributor license agreements." > > I am assuming that each of the above files is an original contribution from > the respective authors to the Kudu project, and not imported from > elsewhere. We need to check that. If the former is the case, we simply > change to the proper header. If the latter is the case, the files need to > be added to the LICENSE.txt file. > > Mike > > [1] https://www.apache.org/legal/src-headers.html > > On Fri, Sep 1, 2017 at 9:53 AM, Dan Burkert <[email protected]> wrote: > > > Hi, > > > > The Apache Kudu team is happy to announce the first release candidate for > > Apache Kudu 1.5.0. > > > > Apache Kudu 1.5.0 is a minor release which offers many improvements and > > fixes since the prior release. > > > > The is a source-only release. The artifacts are staged here: > > https://dist.apache.org/repos/dist/dev/kudu/1.5.0-RC1/ > > > > It is built from this tag: > > https://git-wip-us.apache.org/repos/asf?p=kudu.git;a=commit;h= > > 40012e318401c920dc83c222d6aeba395ed2a6a4 > > > > KEYS file: http://www.apache.org/dist/kudu/KEYS > > > > I suggest going through the README, building Kudu, and running the unit > > tests. > > > > The vote will run until Wednesday, September 6th at 10AM PDT. > > > > Thanks, > > Dan > > >
