It looks like the Kudu committer merging a patch has full control over the strategy currently: [image: image.png]
But in the Kafka project they have limited the available options as seen below. I agree we should configure Kudu to be the same if we go the route of Github reviews. That likely requires an INFRA jira to change. [image: image.png] On Wed, Feb 6, 2019 at 11:36 AM Brock Noland <[email protected]> wrote: > I assume if we used Github PR's we configure merges to occur without merge > commits? I find them very confusing. > > On Wed, Feb 6, 2019 at 9:57 AM Grant Henke <[email protected]> > wrote: > > > Hello Kudu Developers, > > > > Now that Apache is integrated more closely with Github via Gitbox > > <https://gitbox.apache.org/> I wanted to > > open a discussion on the code contribution process. > > > > We now have full control over pull requests and submissions on the Github > > repository meaning we could use Github pull requests for contributions. > > There is likely a long this or advantages and disadvantages to using > Github > > vs Gerrit for reviews. But I think it's something worth evaluating. > > > > Below are some of the pros and cons I came up with: > > > > Pros: > > - More people are familiar with the pull request process > > - Uniform contribution process with other Apache projects > > - Spark, Kafka, Hadoop, Nifi, etc... > > - We don't need push_to_asf.py > > - We don't need to run and manage Cloudera Gerrit > > - We don't need to mirror to a Cloudera repo > > - Support for useful review tools like contribution templates, > > suggested changes, labels, etc > > > > Cons: > > - New workflow for existing contributors > > - WIP patches need to be migrated > > - Effort involved to migrate > > - Notifications > > - Jenkins > > > > What do you think? Is this something worth changing? What are the > benefits > > and drawbacks? > > > > Thank you, > > Grant > > -- > > Grant Henke > > Software Engineer | Cloudera > > [email protected] | twitter.com/gchenke | linkedin.com/in/granthenke > > > -- Grant Henke Software Engineer | Cloudera [email protected] | twitter.com/gchenke | linkedin.com/in/granthenke
