On Wed, Feb 27, 2019 at 3:33 PM Adar Lieber-Dembo <[email protected]> wrote:
> What sorts of patches merit backporting? Off the top of my head: > - Fixes that keep CI working (e.g. pinning of unpinned Python > dependencies that break). > +1, I am even in favor of skipping code review in this case if another committer is not available to review the change. > - Fixes to security vulnerabilities. - Data loss fixes. - Performance fixes, provided the impact:risk ratio is very high. +1, assuming we plan to run an x.y.z release. Put more simply, we should prepare for possible maintenance releases only > for the latest release of Kudu. +1 on assuming we will not do maintenance releases for more than the previously-released version. I agree with the basic criteria you've outlined as good candidates for a maintenance release. However in general I am not in favor of asking committers to backport particular types of patches routinely, because we rarely do maintenance releases. Mike
