[GitHub] [kudu] acelyc111 commented on a change in pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…

[GitBox]

acelyc111 commented on a change in pull request #38:
URL: https://github.com/apache/kudu/pull/38#discussion_r779326416



##########
File path: src/kudu/common/generic_iterators.cc
##########
@@ -191,8 +191,8 @@ class MergeIterState : public 
boost::intrusive::list_base_hook<> {
   }
 
   // Returns the schema from the underlying iterator.
-  const Schema& schema() const {
-    return DCHECK_NOTNULL(iwb_.iter)->schema();

Review comment:
       函数原型应该可以保持不变

##########
File path: src/kudu/common/iterator.h
##########
@@ -57,7 +57,7 @@ class IteratorBase {
   virtual std::string ToString() const = 0;
 
   // Return the schema for the rows which this iterator produces.
-  virtual const Schema &schema() const = 0;

Review comment:
       可以保持不变。
   
   再改一波吧，应该能继续减少改动量




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kudu.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org