Mike Percy has posted comments on this change. Change subject: KUDU-1288. Release WAL file descriptors when deleting tablets ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1715/4/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 832: string cmd = strings::Substitute("export PATH=$$PATH:/usr/bin:/usr/sbin; lsof -p $0 -a /", pid); > why the $$? because of Substitute() Line 880: ASSERT_OK(ets->Restart()); > why not just only shutdown the other servers? or just use a single TS in th Done -- To view, visit http://gerrit.cloudera.org:8080/1715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97dfac521bcd61d2b286c9a437310f40cbe7b288 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
