Adar Dembo has posted comments on this change. Change subject: Add from-source installation instructions for SLES 12 ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/1863/1/docs/installation.adoc File docs/installation.adoc: Line 49: - RHEL 6, Ubuntu 14.04 Trusty, or SLES 12. Reminds me I need to update this for RHEL 7 and Debian 7. Line 415: gdb git libtool make ntp openssl-devel patch pkg-config python rsync unzip vim So it's 'pkgconfig' on RHEL, and 'pkg-config' everywhere else? Line 418: . Install Boost. Should add that Boost can be installed anywhere, just that at the end of the day BOOST_ROOT should be set to wherever it was. Line 449: the `make install` step. The default value is `/usr/local/`. I know you copied this from the other instructions, but I don't understand why we're recommending both DESTDIR (in make install) and CMAKE_INSTALL_PREFIX (in cmake). Don't you just need one or the other? What happens if both are set? Line 455: ../thirdparty/installed/bin/cmake \ May want to re-reference BOOST_ROOT here, or at least in the documentation above. Make it clear that BOOST_ROOT's export is for the cmake invocation. Line 486: export BOOST_ROOT=$(pwd) May be cleaner to just pass BOOST_ROOT=... in the cmake line. -- To view, visit http://gerrit.cloudera.org:8080/1863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I664fd72f0dfdc6801012ee0d9f972cc05679cbd5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Misty Stanley-Jones <[email protected]> Gerrit-HasComments: Yes
