David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1259: new scanner API with an encapsulated Batch object ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/1562/10/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 68: as long as this KuduScanBatch. nit: is it just my non-nativeness or is this missing something at the end of this sentence, or a "for" or something. (feel free to ignore if it is my non-nativeness :)) http://gerrit.cloudera.org:8080/#/c/1562/10/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 475: KuduRowResult you didn't mean to leave this, right? Line 480: KuduRowResult replace Line 482: KuduRowResult same -- To view, visit http://gerrit.cloudera.org:8080/1562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29fd4fbb8b906ffa591853ab625ac4b089da4bc9 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
