Todd Lipcon has posted comments on this change. Change subject: Fix run-test and dist-test to make paths absolute ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/1857/1/README.adoc File README.adoc: Line 219: $ build-support/run-test.sh build/latest/foo-test [--test-arguments-here] > Nit: should be build/tsan/latest/foo-test Done http://gerrit.cloudera.org:8080/#/c/1857/1/build-support/run-test.sh File build-support/run-test.sh: Line 35: # Path to the test executable or script to be run. > Add a comment that this may be relative or absolute. Done Line 39: SOURCE_ROOT=$(dirname $(readlink -f "$BASH_SOURCE"))/.. > Dunno. But on that note, we really need to get pre-commit tests running for changed to using cd and pwd as is done elsewhere Line 52: TEST_PATH=$TEST_DIRNAME/$TEST_FILENAME > May be cleaner to bring back TEST_EXECUTABLE, because then it's easier to e renamed to ABS_TEST_PATH -- To view, visit http://gerrit.cloudera.org:8080/1857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6768d05fc4ae5016813909f819fc9e99f9ebd6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
